Skip to content

Fix ruTorrent utility functions#13

Open
stickz wants to merge 1 commit intoradonthetyrant:masterfrom
stickz:ruTorrentFixes
Open

Fix ruTorrent utility functions#13
stickz wants to merge 1 commit intoradonthetyrant:masterfrom
stickz:ruTorrentFixes

Conversation

@stickz
Copy link
Copy Markdown

@stickz stickz commented Jan 13, 2022

The utility functions were recently changed in ruTorrent. Novik/ruTorrent#2247 They are no longer in the global scope. It's required to access these static methods from their respective classes now.

This intention of this pull request is to make the rutorrent-discord plugin compatible with these changes.

Please note: I was not able to setup a testing environment for these changes. This means I was not able to test this PR. These changes can be tested by getting the latest master branch commit of ruTorrent here: https://github.com/Novik/ruTorrent

If any further changes are required or my changes do not work, please feel free to let me know.

@Emsung
Copy link
Copy Markdown

Emsung commented Apr 1, 2022 •
edited
Loading

Hiya,

[01.04.2022 18:55:15] JS error: [https://xxx.xxx.xxx.xxx/rutorrent/ : 1] Uncaught SyntaxError: Unexpected token '<' when using your fork.

@stickz
Copy link
Copy Markdown
Author

stickz commented Apr 2, 2022

Hi @Emsung, could you go to developer tools-> console -> info on google chrome and post the stack trace? It's required to run the latest master version of ruTorrent for this feature to work. It should give me enough info to fix the problem.

developer_tools_info

@Emsung
Copy link
Copy Markdown

Emsung commented Apr 2, 2022

Hi @stickz, there is no info message in console, only in the log viewer of rutorrent main window.

I'm running rutorrent 3.10, i've tried different forks and all give me the same error.

When i remove the discordpush folder out of plugins rutorrent loads.

When i rename discord.php i get the following message:
[02.04.2022 15:31:16] discordpush: Plugin will not work. rTorrent user must have read access to the file (/srv/rutorrent/plugins/discordpush/discord.php).

@george2781
Copy link
Copy Markdown

george2781 commented Jun 15, 2024

This fixes #15 from the looks of things

@george2781 george2781 mentioned this pull request Jun 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stickz @Emsung @george2781